Postgres Pro
Downloads
Home   >   mailing lists

Thread: [GSoC] Help with Jasmine Tests

[GSoC] Help with Jasmine Tests

From
Yosry Muhammad
Date:
Hi all,

I am writing tests for my initial patch of my Google Summer of Code project, which allows editing of SQL queries results (if they are updatable).

I am trying to write a test for the sqleditor that checks that if _render() function (in sqleditor.js) is called with w query results that include primary keys, then the grid should be editable (I need to check grid options, gridView.grid.getOptions() ).

I also want to check that if the user edits a cell in the grid, the Save Data button (new button) is enabled. Is this feasible ?

Can anyone help me? I am new to front-end tests. In the sqleditor test I have seen, a spy is created for the SqlEditor to see if specific functions are called, but I want the actual _render() function to run (to call render_grid() of the gridView). In other words, I need to test the code inside_render() function.

Thanks a lot.

--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.

Re: [GSoC] Help with Jasmine Tests

From
Aditya Toshniwal
Date:
Hi Yosry,

On Sat, Jun 29, 2019 at 8:54 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi all,

I am writing tests for my initial patch of my Google Summer of Code project, which allows editing of SQL queries results (if they are updatable).
This will help you kick start with Jasmin test cases. 

I am trying to write a test for the sqleditor that checks that if _render() function (in sqleditor.js) is called with w query results that include primary keys, then the grid should be editable (I need to check grid options, gridView.grid.getOptions() ).

I also want to check that if the user edits a cell in the grid, the Save Data button (new button) is enabled. Is this feasible ?
This is similar to what is done in - web/regression/javascript/sqleditor/execute_query_spec.js  for btn-flash.

Can anyone help me? I am new to front-end tests. In the sqleditor test I have seen, a spy is created for the SqlEditor to see if specific functions are called, but I want the actual _render() function to run (to call render_grid() of the gridView). In other words, I need to test the code inside_render() function.
Currently, _render is not directly testable using jasmine test cases. You need to break down the code to make it more testable. You can read through articles like - https://hackernoon.com/how-to-refactor-unwieldy-untestable-code-4a73d75cb80a to get an idea. An example in pgAdmin would be web/pgadmin/static/js/sqleditor/execute_query.js

Thanks a lot.

--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Re: [GSoC] Help with Jasmine Tests

From
Yosry Muhammad
Date:
Thanks for your help, I will see what I can do.

On Mon, Jul 1, 2019, 8:57 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Yosry,

On Sat, Jun 29, 2019 at 8:54 PM Yosry Muhammad <yosrym93@gmail.com> wrote:
Hi all,

I am writing tests for my initial patch of my Google Summer of Code project, which allows editing of SQL queries results (if they are updatable).
This will help you kick start with Jasmin test cases. 

I am trying to write a test for the sqleditor that checks that if _render() function (in sqleditor.js) is called with w query results that include primary keys, then the grid should be editable (I need to check grid options, gridView.grid.getOptions() ).

I also want to check that if the user edits a cell in the grid, the Save Data button (new button) is enabled. Is this feasible ?
This is similar to what is done in - web/regression/javascript/sqleditor/execute_query_spec.js  for btn-flash.

Can anyone help me? I am new to front-end tests. In the sqleditor test I have seen, a spy is created for the SqlEditor to see if specific functions are called, but I want the actual _render() function to run (to call render_grid() of the gridView). In other words, I need to test the code inside_render() function.
Currently, _render is not directly testable using jasmine test cases. You need to break down the code to make it more testable. You can read through articles like - https://hackernoon.com/how-to-refactor-unwieldy-untestable-code-4a73d75cb80a to get an idea. An example in pgAdmin would be web/pgadmin/static/js/sqleditor/execute_query.js

Thanks a lot.

--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

Re: [GSoC] Help with Jasmine Tests

From
Yosry Muhammad
Date:


On Mon, Jul 1, 2019 at 8:57 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

I am trying to write a test for the sqleditor that checks that if _render() function (in sqleditor.js) is called with w query results that include primary keys, then the grid should be editable (I need to check grid options, gridView.grid.getOptions() ).

I also want to check that if the user edits a cell in the grid, the Save Data button (new button) is enabled. Is this feasible ?
This is similar to what is done in - web/regression/javascript/sqleditor/execute_query_spec.js  for btn-flash.

The problem is not with checking the button. How do I mimic the user editing the grid? I cannot create a grid with all its options in the test.

--
Yosry Muhammad Yosry

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.