Thread: Comment fix of config_default.pl
Hello.
In src/tools/msvc/config_default.pl, peremeter "perl" requires a
path string, not a bool differently from that of configure
script. --with-python has the same characteristics and the
comment is suggesting that.
We need to fix --with-perl and --with-uuid the same way.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/tools/msvc/config_default.pl b/src/tools/msvc/config_default.pl
index 2553636dc1..9f37ba53f8 100644
--- a/src/tools/msvc/config_default.pl
+++ b/src/tools/msvc/config_default.pl
@@ -18,10 +18,10 @@ our $config = {
nls => undef, # --enable-nls=<path>
tap_tests => undef, # --enable-tap-tests
tcl => undef, # --with-tcl=<path>
- perl => undef, # --with-perl
+ perl => undef, # --with-perl=<path>
python => undef, # --with-python=<path>
openssl => undef, # --with-openssl=<path>
- uuid => undef, # --with-ossp-uuid
+ uuid => undef, # --with-ossp-uuid=<path>
xml => undef, # --with-libxml=<path>
xslt => undef, # --with-libxslt=<path>
iconv => undef, # (not in configure, path to iconv)
On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote: > In src/tools/msvc/config_default.pl, parameter "perl" requires a > path string, not a bool differently from that of configure > script. --with-python has the same characteristics and the > comment is suggesting that. > > We need to fix --with-perl and --with-uuid the same way. > > + uuid => undef, # --with-ossp-uuid=<path> --with-ossp-uuid is an obsolete spelling. Wouldn't it be better to replace it with --with-uuid=<path>? That would be a bit inconsistent with configure which can only take a set of hardcoded names, still there is little point in keeping an option which would get removed sooner than later? -- Michael
Attachment
Thanks.
At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190712040113.GD2149@paquier.xyz>
> On Fri, Jul 12, 2019 at 12:15:29PM +0900, Kyotaro Horiguchi wrote:
> > In src/tools/msvc/config_default.pl, parameter "perl" requires a
> > path string, not a bool differently from that of configure
> > script. --with-python has the same characteristics and the
> > comment is suggesting that.
> >
> > We need to fix --with-perl and --with-uuid the same way.
> >
> > + uuid => undef, # --with-ossp-uuid=<path>
>
> --with-ossp-uuid is an obsolete spelling. Wouldn't it be better to
> replace it with --with-uuid=<path>? That would be a bit inconsistent
Oops! Right. My eyes slipped over the difference..
> with configure which can only take a set of hardcoded names, still
> there is little point in keeping an option which would get removed
> sooner than later?
Agreed. Attached the fixed version.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
From 621cd2a6c63b4ae99a51dd3a082d889cf7de286f Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Fri, 12 Jul 2019 15:20:27 +0900
Subject: [PATCH] Fix comments in config_default.pl
Each configuration option in config_default.pl corresponds to one of
the configure script options but some of the correspondents of boolean
or item-selection options take path string. Such options are suggested
to do so in their comments, but "perl" and "uuid" options were
forgotten. Modify them so. --with-ossp-uuid is changed to --with-uuid
since it is obsolete.
---
src/tools/msvc/config_default.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/tools/msvc/config_default.pl b/src/tools/msvc/config_default.pl
index 2553636dc1..043df4c5e8 100644
--- a/src/tools/msvc/config_default.pl
+++ b/src/tools/msvc/config_default.pl
@@ -18,10 +18,10 @@ our $config = {
nls => undef, # --enable-nls=<path>
tap_tests => undef, # --enable-tap-tests
tcl => undef, # --with-tcl=<path>
- perl => undef, # --with-perl
+ perl => undef, # --with-perl=<path>
python => undef, # --with-python=<path>
openssl => undef, # --with-openssl=<path>
- uuid => undef, # --with-ossp-uuid
+ uuid => undef, # --with-uuid=<path>
xml => undef, # --with-libxml=<path>
xslt => undef, # --with-libxslt=<path>
iconv => undef, # (not in configure, path to iconv)
--
2.16.3
On Fri, Jul 12, 2019 at 03:34:11PM +0900, Kyotaro Horiguchi wrote: > At Fri, 12 Jul 2019 13:01:13 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190712040113.GD2149@paquier.xyz> >> --with-ossp-uuid is an obsolete spelling. Wouldn't it be better to >> replace it with --with-uuid=<path>? That would be a bit inconsistent > > Oops! Right. My eyes slipped over the difference.. I would also patch GetFakeConfigure in Solution.pm (no need to send a new patch), and I thought that you'd actually do the change. What do you think? -- Michael
Attachment
On Fri, Jul 12, 2019 at 05:01:41PM +0900, Michael Paquier wrote: > I would also patch GetFakeConfigure in Solution.pm (no need to send a > new patch), and I thought that you'd actually do the change. What do > you think? OK, applied as I have been able to look at it again, and after fixing the portion for GetFakeConfigure. Thanks! -- Michael
Attachment
At Sat, 13 Jul 2019 16:53:45 +0900, Michael Paquier <michael@paquier.xyz> wrote in <20190713075345.GC2137@paquier.xyz> > On Fri, Jul 12, 2019 at 05:01:41PM +0900, Michael Paquier wrote: > > I would also patch GetFakeConfigure in Solution.pm (no need to send a > > new patch), and I thought that you'd actually do the change. What do > > you think? > > OK, applied as I have been able to look at it again, and after fixing > the portion for GetFakeConfigure. Thanks! Thanks for committing and your additional part. regards. -- Kyotaro Horiguchi NTT Open Source Software Center