Postgres Pro
Downloads
Home   >   mailing lists

Thread: Somebody broke commit hook for git push --tags?

Somebody broke commit hook for git push --tags?

From
Tom Lane
Date:
When I tried to push the RC1 tag to gitmaster just now, I got

$ git push --tags
Total 0 (delta 0), reused 0 (delta 0)
remote: Traceback (most recent call last):
remote:   File "hooks/post-receive", line 414, in <module>
remote:     raise Exception("Unknown tag type '%s'" % t)
remote: Exception: Unknown tag type 'b'commit''
To ssh://git@gitmaster.postgresql.org/postgresql.git
 * [new tag]         REL_12_RC1 -> REL_12_RC1
$

It looks like the tag got pushed anyway, but this was a bit scary.

            regards, tom lane

Re: Somebody broke commit hook for git push --tags?

From
Magnus Hagander
Date:
On Wed, Sep 25, 2019 at 12:20 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
When I tried to push the RC1 tag to gitmaster just now, I got

$ git push --tags
Total 0 (delta 0), reused 0 (delta 0)
remote: Traceback (most recent call last):
remote:   File "hooks/post-receive", line 414, in <module>
remote:     raise Exception("Unknown tag type '%s'" % t)
remote: Exception: Unknown tag type 'b'commit''
To ssh://git@gitmaster.postgresql.org/postgresql.git
 * [new tag]         REL_12_RC1 -> REL_12_RC1
$

It looks like the tag got pushed anyway, but this was a bit scary.


That was indeed me. *This* was fallout from that deployment I did a few days ago that I was initially blaming a different problem on.

I've pushed what I believe is a fix to that.

//Magnus