Thread: allow_system_table_mods and DROP RULE
As a curious omission, DROP RULE does not check allow_system_table_mods. Creating and renaming a rule does, and also creating, renaming, and dropping a trigger does. The impact of this is probably nil in practice, but for consistency we should probably add that. The patch is pretty simple. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment
On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > As a curious omission, DROP RULE does not check allow_system_table_mods. > Creating and renaming a rule does, and also creating, renaming, and > dropping a trigger does. The impact of this is probably nil in > practice, but for consistency we should probably add that. The patch is > pretty simple. +1. LGTM. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 2019-12-18 16:53, Robert Haas wrote: > On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut > <peter.eisentraut@2ndquadrant.com> wrote: >> As a curious omission, DROP RULE does not check allow_system_table_mods. >> Creating and renaming a rule does, and also creating, renaming, and >> dropping a trigger does. The impact of this is probably nil in >> practice, but for consistency we should probably add that. The patch is >> pretty simple. > > +1. LGTM. committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services