Thread: [pgAdmin][RM5115] RULE SQL incorrectly generated

[pgAdmin][RM5115] RULE SQL incorrectly generated

From
Aditya Toshniwal
Date:
Hi Hackers,

Attached is the patch to fix the SQL parsing issue in rules. The command and statements were parsed incorrectly.
Also fixed issue where removing command or statements altogether was not generating modified SQL and so was not saving.
Test cases added and changed accordingly.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][RM5115] RULE SQL incorrectly generated

From
Akshay Joshi
Date:
Thanks, patch applied.

On Fri, Feb 21, 2020 at 3:10 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the SQL parsing issue in rules. The command and statements were parsed incorrectly.
Also fixed issue where removing command or statements altogether was not generating modified SQL and so was not saving.
Test cases added and changed accordingly.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246