Thread: [pgAdmin][RM3851] Add proper indentation to the code when generatinga stored procedure

Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:

1. Stored procedure code indentation.
2. Functions code indentation.
3. Trigger Functions code indentation.

Please review.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:

BEGIN

      SELECT 1;

END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:

1. Stored procedure code indentation.
2. Functions code indentation.
3. Trigger Functions code indentation.

Please review.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

Hi Akshay,

I have made the relevant changes for existing and the new procedure, functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:

BEGIN

      SELECT 1;

END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:

1. Stored procedure code indentation.
2. Functions code indentation.
3. Trigger Functions code indentation.

Please review.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

Akshay,

Ignore the above patch, reconsider this latest patch with some optimizations.

On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Hi Akshay,

I have made the relevant changes for existing and the new procedure, functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:

BEGIN

      SELECT 1;

END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:

1. Stored procedure code indentation.
2. Functions code indentation.
3. Trigger Functions code indentation.

Please review.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

Corrected some indentations. Find the patch below.

On Sun, Jun 28, 2020 at 9:21 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Akshay,

Ignore the above patch, reconsider this latest patch with some optimizations.

On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Hi Akshay,

I have made the relevant changes for existing and the new procedure, functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:

BEGIN

      SELECT 1;

END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:

Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:

1. Stored procedure code indentation.
2. Functions code indentation.
3. Trigger Functions code indentation.

Please review.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.

--

Rahul Shirsat

Software Engineer | EnterpriseDB Corporation.