Postgres Pro
Downloads
Home   >   mailing lists

Thread: [pgAdmin][SonarQube] Reduce cognitive complexity

[pgAdmin][SonarQube] Reduce cognitive complexity

From
Aditya Toshniwal
Date:
Attached patch reduces the cognitive complexity as below:
web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15
web/pgadmin/utils/driver/psycopg2/connection.py - 16 to 15
web/setup.py - 17 to 15

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

From
Akshay Joshi
Date:
Thanks, patch applied.

On Tue, Sep 8, 2020 at 6:13 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Attached patch reduces the cognitive complexity as below:
web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15
web/pgadmin/utils/driver/psycopg2/connection.py - 16 to 15
web/setup.py - 17 to 15

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246