Thread: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

Hi Hackers,

Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format.

--

Thanks & Regards,

Pradip Parkale
Software Engineer | EnterpriseDB Corporation

Hi Pradip,

Just did a go through to your patch. 

The variable "data" which you've formed, will be computed for every row even though columns won't change. You should move it up and pass it to gen directly. This will save repeated computations.

Secondly, it should not be named as data. It can be like - numeric_cols or numeric_keys.

On Fri, Jun 11, 2021 at 7:17 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:

Hi Hackers,

Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format.

--

Thanks & Regards,

Pradip Parkale
Software Engineer | EnterpriseDB Corporation

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"