Thread: pgsql: Don't allow to set replication slot_name as ''.

pgsql: Don't allow to set replication slot_name as ''.

From

Amit Kapila

Date:

19 July 2021, 06:10:21

Don't allow to set replication slot_name as ''.

We don't allow to create replication slot_name as an empty string ('') via
SQL API pg_create_logical_replication_slot() but it is allowed to be set
via Alter Subscription command. This will lead to apply worker repeatedly
keep trying to stream data via slot_name '' and the user is not allowed to
create the slot with that name.

Author: Japin Li
Reviewed-By: Ranier Vilela, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/29abde637bbb4b8fcdc96e049813890afa5ab671

Modified Files
--------------
src/backend/commands/subscriptioncmds.c    | 2 ++
src/test/regress/expected/subscription.out | 3 +++
src/test/regress/sql/subscription.sql      | 3 +++
3 files changed, 8 insertions(+)