Thread: pgsql: Avoid using ambiguous word "non-negative" in error messages.
Avoid using ambiguous word "non-negative" in error messages. The error messages using the word "non-negative" are confusing because it's ambiguous about whether it accepts zero or not. This commit improves those error messages by replacing it with less ambiguous word like "greater than zero" or "greater than or equal to zero". Also this commit added the note about the word "non-negative" to the error message style guide, to help writing the new error messages. When postgres_fdw option fetch_size was set to zero, previously the error message "fetch_size requires a non-negative integer value" was reported. This error message was outright buggy. Therefore back-patch to all supported versions where such buggy error message could be thrown. Reported-by: Hou Zhijie Author: Bharath Rupireddy Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/OS0PR01MB5716415335A06B489F1B3A8194569@OS0PR01MB5716.jpnprd01.prod.outlook.com Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/78c21d79d72aa38cfe4a16b232aaf9d723b20378 Modified Files -------------- contrib/postgres_fdw/option.c | 13 ++++++++----- doc/src/sgml/sources.sgml | 10 ++++++++++ src/backend/utils/adt/tsquery_op.c | 2 +- src/test/modules/test_shm_mq/test.c | 10 +++++----- 4 files changed, 24 insertions(+), 11 deletions(-)