Thread: Patch for pgarchives project
There is no requirements.txt file in pgarchives project. This type of file containing dependencies for python projects can help beginners to get started. I am attaching a patch for the issue.
with regards,
Girish Sontakke
Attachment
[PATCH] created requirements.txt file containing dependencies of the project
From
girishsontakke
Date:
--- requirements.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 requirements.txt diff --git a/requirements.txt b/requirements.txt new file mode 100644 index 0000000..9109c91 --- /dev/null +++ b/requirements.txt @@ -0,0 +1,12 @@ +asgiref==3.5.0 +backports.zoneinfo==0.2.1 +certifi==2021.10.8 +charset-normalizer==2.0.12 +Django==3.0 +idna==3.3 +psycopg2==2.9.3 +pycryptodomex==3.14.1 +pytz==2022.1 +requests==2.27.1 +sqlparse==0.4.2 +urllib3==1.26.9 -- 2.33.0
Hi, On 3/23/22 2:11 PM, Girish Sontakke wrote: > There is no requirements.txt file in pgarchives project > <https://github.com/postgres/pgarchives>. This type of file containing > dependencies for python projects can help beginners to get started. I am > attaching a patch for the issue. Thanks for doing this! I agree. I would need to double-check the dependencies, but otherwise this seems reasonable. Thanks, Jonathan
Attachment
On Thu, Mar 24, 2022 at 3:22 PM Jonathan S. Katz <jkatz@postgresql.org> wrote:
Hi,
On 3/23/22 2:11 PM, Girish Sontakke wrote:
> There is no requirements.txt file in pgarchives project
> <https://github.com/postgres/pgarchives>. This type of file containing
> dependencies for python projects can help beginners to get started. I am
> attaching a patch for the issue.
Thanks for doing this! I agree.
I would need to double-check the dependencies, but otherwise this seems
reasonable.
The dependencies are definitely wrong. I only took a very quick look, but it specifies Django 3.0 which is incorrect since we use Django 3.2 (LTS).
Where did you come up with the list of versions?
(And yes, I agree that in general it makes sense to have such a list)
I come up with the list by the hit and trial method. I am new to the project so I also faced the same problem of lack of documentation for setup.
On Tue, Mar 29, 2022 at 2:11 AM Magnus Hagander <magnus@hagander.net> wrote:
On Thu, Mar 24, 2022 at 3:22 PM Jonathan S. Katz <jkatz@postgresql.org> wrote:Hi,
On 3/23/22 2:11 PM, Girish Sontakke wrote:
> There is no requirements.txt file in pgarchives project
> <https://github.com/postgres/pgarchives>. This type of file containing
> dependencies for python projects can help beginners to get started. I am
> attaching a patch for the issue.
Thanks for doing this! I agree.
I would need to double-check the dependencies, but otherwise this seems
reasonable.The dependencies are definitely wrong. I only took a very quick look, but it specifies Django 3.0 which is incorrect since we use Django 3.2 (LTS).Where did you come up with the list of versions?(And yes, I agree that in general it makes sense to have such a list)--