Home > mailing lists

Thread: [Patch] - Housekeeping #7315 - Update pgAdmin4 doc for Traefikv2 containerization

From

Yogesh Mahajan

Date:

02 June 2022, 09:37:08

Hi,

Please find the attached patch which updates documentation for Traefik v2 container deployment.

Thanks,

Yogesh Mahajan

EnterpriseDB

From

Akshay Joshi

Date:

02 June 2022, 12:42:12

Thanks, the patch applied

On Thu, Jun 2, 2022 at 3:07 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:

Hi,

Please find the attached patch which updates documentation for Traefik v2 container deployment.

Thanks,
Yogesh Mahajan
EnterpriseDB

Akshay Joshi

Principal Software Architect

+91 9767888246

From

Khushboo Vashi

Date:

06 June 2022, 06:16:53

Hi Yogesh,

Review comments:

Step 2: The below statements should be in a different line, like
- "Azure CLI" will use the currently logged in identity through Azure CLI on the local machine.
- "Interactive Browser" opens a browser to authenticate a user interactively.
Disable the next button once authentication is complete.
Cluster name availability call calls the server on every field change
Availability zone needs description
Add High availability option

Code:

check_cluster_name_availability should be using the GET method instead of Post
Fix SonarLint issues
Do we need the cache_persistence_options as it will create the persistent storage which we do not require I guess?
Why do we need to call _get_azure_credentials on every request? Can't we store it in the session object?
Use gettext wherever required in the js file

Thanks,

Khushboo

On Thu, Jun 2, 2022 at 3:07 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:

Hi,

Please find the attached patch which updates documentation for Traefik v2 container deployment.

Thanks,
Yogesh Mahajan
EnterpriseDB