Thread: [pgAdmin 4][Patch] - Cloud Deployment - Fixed Review Comments
Attachment
Hi Khushboo
Please fix the pep8, linter, and jasmine test cases.
On Wed, Jun 8, 2022 at 1:35 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hello,Please find the attached patch to fix the review comments given in the Cloud Deployment demo:- Added High Availability option- Server group renamed to pgAdmin server group- Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin.Thanks,Khushboo
Hi Akshay,
Please find the attached updated patch.
On Wed, Jun 8, 2022 at 3:56 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi KhushbooPlease fix the pep8, linter, and jasmine test cases.
Fixed.
Thanks,
Khushboo
On Wed, Jun 8, 2022 at 1:35 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hello,Please find the attached patch to fix the review comments given in the Cloud Deployment demo:- Added High Availability option- Server group renamed to pgAdmin server group- Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin.Thanks,Khushboo--
Attachment
Thanks, the patch applied.
On Thu, Jun 9, 2022 at 11:53 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,Please find the attached updated patch.On Wed, Jun 8, 2022 at 3:56 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi KhushbooPlease fix the pep8, linter, and jasmine test cases.Fixed.Thanks,KhushbooOn Wed, Jun 8, 2022 at 1:35 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:Hello,Please find the attached patch to fix the review comments given in the Cloud Deployment demo:- Added High Availability option- Server group renamed to pgAdmin server group- Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin.Thanks,Khushboo--