Thread: [pgAdmin][patch] Theme component usage fix
Attachment
Hi Aditya
Can you please rebase and send the patch again.
On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"
Hi,
Attached is the rebased patch.
On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
Hi Aditya
Please fix the linter error and send the patch again.
On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Hi,
Attached is the updated patch.
On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi AdityaPlease fix the linter error and send the patch again.On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
Thanks, the patch applied.
On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,Attached is the updated patch.On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaPlease fix the linter error and send the patch again.On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Hi,
Attached patch fixes the failing JS test cases.
On Thu, Jun 30, 2022 at 3:19 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the updated patch.On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaPlease fix the linter error and send the patch again.On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
Thanks, the patch applied.
On Fri, Jul 1, 2022 at 2:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,Attached patch fixes the failing JS test cases.On Thu, Jun 30, 2022 at 3:19 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the updated patch.On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaPlease fix the linter error and send the patch again.On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Hi,
Attached a few more fixes related to theme usage.
On Fri, Jul 1, 2022 at 3:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.On Fri, Jul 1, 2022 at 2:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached patch fixes the failing JS test cases.On Thu, Jun 30, 2022 at 3:19 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the updated patch.On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaPlease fix the linter error and send the patch again.On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
Hi,
Please ignore the previous patch. Please review the attached patch.
On Mon, Jul 4, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,Attached a few more fixes related to theme usage.On Fri, Jul 1, 2022 at 3:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Fri, Jul 1, 2022 at 2:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached patch fixes the failing JS test cases.On Thu, Jun 30, 2022 at 3:19 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the updated patch.On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaPlease fix the linter error and send the patch again.On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment
Thanks, the patch applied
On Mon, Jul 4, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,Please ignore the previous patch. Please review the attached patch.On Mon, Jul 4, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached a few more fixes related to theme usage.On Fri, Jul 1, 2022 at 3:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Fri, Jul 1, 2022 at 2:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached patch fixes the failing JS test cases.On Thu, Jun 30, 2022 at 3:19 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Thu, Jun 30, 2022 at 3:03 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the updated patch.On Thu, Jun 30, 2022 at 2:26 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaPlease fix the linter error and send the patch again.On Thu, Jun 30, 2022 at 2:12 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi,Attached is the rebased patch.On Thu, Jun 30, 2022 at 2:06 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi AdityaCan you please rebase and send the patch again.On Thu, Jun 30, 2022 at 1:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:Hi Hackers,Attached patch fixes the usage of the Theme component.Please note, a component should not be wrapped in multiple Theme components as it will create styling issues.--Thanks,Aditya ToshniwalpgAdmin Hacker | Software Architect | edbpostgres.com"Don't Complain about Heat, Plant a TREE"--