Thread: pgAdmin 4 commit: Fixed the following code smells:

pgAdmin 4 commit: Fixed the following code smells:

From

Akshay Joshi

Date:

10 September 2022, 08:53:37

Fixed the following code smells:
1. Use concise character class syntax
2. Add a "break" statement or remove this "else" clause.
3. Replace this generic exception class with a more specific one.
4. Use a regular expression literal instead of the 'RegExp' constructor.
5. Use the opposite operator ("not in") instead.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbf58864309db9ed935401f6b2bd7132b5524ea0
Author: Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>

Modified Files
--------------
.../server_groups/servers/pgagent/__init__.py      |  2 +-
.../servers/pgagent/steps/__init__.py              |  2 +-
.../server_groups/servers/roles/__init__.py        | 15 ++++--------
web/pgadmin/browser/static/js/datamodel.js         |  6 ++---
web/pgadmin/static/js/components/CodeMirror.jsx    |  3 +--
web/pgadmin/static/js/pgadmin.js                   |  2 +-
web/pgadmin/static/js/validators.js                |  6 ++---
.../search_objects/static/js/SearchObjects.jsx     |  2 +-
.../utils/sqlautocomplete/parseutils/ctes.py       |  2 +-
.../utils/sqlautocomplete/parseutils/tables.py     |  2 +-
.../feature_tests/pg_datatype_validation_test.py   |  6 -----
.../feature_tests/query_tool_journey_test.py       |  2 +-
web/regression/feature_utils/pgadmin_page.py       | 27 ++--------------------
13 files changed, 19 insertions(+), 58 deletions(-)