Postgres Pro
Downloads
Home   >   mailing lists

Thread: Alignment issue at 43.10. Trigger Functions

Alignment issue at 43.10. Trigger Functions

From
PG Doc comments form
Date:
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html
Description:

Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
Function for Auditing":

CREATE TABLE emp_audit(
    operation         char(1)   NOT NULL,
    stamp             timestamp NOT NULL,
    userid            text      NOT NULL,
    empname           text      NOT NULL,
    salary integer
);

Re: Alignment issue at 43.10. Trigger Functions

From
Laurenz Albe
Date:
On Thu, 2022-11-17 at 18:14 +0000, PG Doc comments form wrote:
> Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html
> 
> Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
> Function for Auditing":
> 
> CREATE TABLE emp_audit(
>     operation         char(1)   NOT NULL,
>     stamp             timestamp NOT NULL,
>     userid            text      NOT NULL,
>     empname           text      NOT NULL,
>     salary integer
> );

Attached is a patch to fix that.

Yours,
Laurenz Albe
Attachment

Re: Alignment issue at 43.10. Trigger Functions

From
Daniel Gustafsson
Date:
> On 18 Nov 2022, at 07:21, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> 
> On Thu, 2022-11-17 at 18:14 +0000, PG Doc comments form wrote:
>> Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html
>> 
>> Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
>> Function for Auditing":
>> 
>> CREATE TABLE emp_audit(
>>     operation         char(1)   NOT NULL,
>>     stamp             timestamp NOT NULL,
>>     userid            text      NOT NULL,
>>     empname           text      NOT NULL,
>>     salary integer
>> );
> 
> Attached is a patch to fix that.

There was a second occurrence of the above, as well as one table which had no
vertical alignment at all.  I fixed these and applied your patch to master.

--
Daniel Gustafsson        https://vmware.com/

Re: Alignment issue at 43.10. Trigger Functions

From
Laurenz Albe
Date:
On Fri, 2022-12-02 at 11:42 +0100, Daniel Gustafsson wrote:
> 
> I fixed these and applied your patch to master.

Thanks for taking care of this small matter.

Yours,
Laurenz Albe