Thread: pgsql: Remove dead code in formatting.c

Remove dead code in formatting.c

Remove some code guarded by IS_MINUS() or IS_PLUS(), where the entire
stanza is inside an else-block where both of these are false. This
should slightly improve test coverage.

While at it, remove coding that apparently assumes that unsetting a
bit is so expensive that we have to first check if it's already set
in the first place.

Per Coverity report from Ranier Vilela
Analysis and review by Justin Pryzby

Discussion: https://www.postgresql.org/message-id/20221223010818.GP1153%40telsasoft.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e29c5653434ebf6a88d009746d21ca3a59ddb69b

Modified Files
--------------
src/backend/utils/adt/formatting.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)