Thread: Minipatch concerning tags

Hello!
PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya, Oleg Sibiryakov and me) have prepared a patch with some improvements concerning missed/inapt tags. Please have a look.

On Fri, Oct 20, 2023 at 11:22:55AM +0300, Maxim Yablokov wrote:
> PostgresPro documentation team (Ekaterina Kiryanova, Elena Indrupskaya, Oleg
> Sibiryakov and me) have prepared a patch with some improvements concerning
> missed/inapt tags. Please have a look.

Most of what you are proposing makes sense.

> -     It means that, for walsenders which are lagging (if any), some WAL records up
> +     It means that, for <literal>walsender</literal>s that are lagging (if any),

But not this one.  This could just be "WAL senders", but we also use
the term "walsender" in physical and logical replication areas, so a
plural looks OK for me here, leaving it as it is now.
--
Michael

On Sat, Oct 21, 2023 at 04:11:50PM +0900, Michael Paquier wrote:
> But not this one.  This could just be "WAL senders", but we also use
> the term "walsender" in physical and logical replication areas, so a
> plural looks OK for me here, leaving it as it is now.

I have reverted this change, added one markup for a catalog_xmin that
was missed, fixed a few whitespaces, and applied it on HEAD.

Thanks!
--
Michael

Hello!

Thanks a lot!

We have also prepared a small patch concerning spelling, punctuation, etc. We've decided to send it separately, so it'll be easier to review. Please have a look.

(just in case: e.kiryanova@postgrespro.ru, e.indrupskaya@postgrespro.ru, o.sibiryakov@postgrespro.ru, m.yablokov@postgrespro.ru)

On Sat, Oct 21, 2023 at 04:11:50PM +0900, Michael Paquier wrote:

But not this one.  This could just be "WAL senders", but we also use
the term "walsender" in physical and logical replication areas, so a
plural looks OK for me here, leaving it as it is now.

I have reverted this change, added one markup for a catalog_xmin that
was missed, fixed a few whitespaces, and applied it on HEAD. 

Thanks!
--
Michael

On Mon, Oct 23, 2023 at 12:33:03PM +0300, Maxim Yablokov wrote:
> We have also prepared a small patch concerning spelling, punctuation, etc.
> We've decided to send it separately, so it'll be easier to review. Please
> have a look.

Yep, these are improvements.  So applied and backpatched (all these
applied down to 16, except for one down to 11).

> (just in case: e.kiryanova@postgrespro.ru, e.indrupskaya@postgrespro.ru,
> o.sibiryakov@postgrespro.ru, m.yablokov@postgrespro.ru)

Thanks for the list.  I've used that in the commit message.
--
Michael