Postgres Pro
Downloads
Home   >   mailing lists

Thread: PG docs - Sequence CYCLE clause

PG docs - Sequence CYCLE clause

From
Peter Smith
Date:
Hi hackers.

While reviewing another thread I had cause to be looking more
carefully at the SEQUENCE documentation.

I found it curious that, unlike other clauses, the syntax of the CYCLE
clause was not displayed on a line by itself.

I have changed that, and at the same time I have moved the CYCLE
syntax (plus its description) to be adjacent to MINVALUE/MAXVALUE,
which IMO is where it naturally belongs.

Please see the attached patch.

Thoughts?

======
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachment

Re: PG docs - Sequence CYCLE clause

From
Peter Eisentraut
Date:
On 13.08.24 07:46, Peter Smith wrote:
> While reviewing another thread I had cause to be looking more
> carefully at the SEQUENCE documentation.
> 
> I found it curious that, unlike other clauses, the syntax of the CYCLE
> clause was not displayed on a line by itself.
> 
> I have changed that, and at the same time I have moved the CYCLE
> syntax (plus its description) to be adjacent to MINVALUE/MAXVALUE,
> which IMO is where it naturally belongs.
> 
> Please see the attached patch.

I agree, it makes a bit more sense with your patches.

Re: PG docs - Sequence CYCLE clause

From
Bruce Momjian
Date:
On Wed, Aug 14, 2024 at 01:46:23PM +0200, Peter Eisentraut wrote:
> On 13.08.24 07:46, Peter Smith wrote:
> > While reviewing another thread I had cause to be looking more
> > carefully at the SEQUENCE documentation.
> > 
> > I found it curious that, unlike other clauses, the syntax of the CYCLE
> > clause was not displayed on a line by itself.
> > 
> > I have changed that, and at the same time I have moved the CYCLE
> > syntax (plus its description) to be adjacent to MINVALUE/MAXVALUE,
> > which IMO is where it naturally belongs.
> > 
> > Please see the attached patch.
> 
> I agree, it makes a bit more sense with your patches.

Great, patch applied to master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.

Re: PG docs - Sequence CYCLE clause

From
Peter Smith
Date:
On Tue, Aug 20, 2024 at 10:18 AM Bruce Momjian <bruce@momjian.us> wrote:
>
> Great, patch applied to master.
>

Thanks for pushing!

======
Kind Regards,
Peter Smith.
Fujitsu Australia