Thread: pgsql: Remove dependence on -fwrapv semantics in jsonb.
Remove dependence on -fwrapv semantics in jsonb. This commit updates a couple of places in the jsonb code to no longer rely on signed integer wrapping for correctness. Like commit 9e9a2b7031, this is intended to move us closer towards removing -fwrapv, which may enable some compiler optimizations. However, there is presently no plan to actually remove that compiler option in the near future. This commit makes use of the newly introduced pg_abs_s32() routine to negate a signed integer (that is known to be negative) for comparison with an unsigned integer. In passing, change one use of INT_MIN to the more portable PG_INT32_MIN. Reported-by: Alexander Lakhin Author: Joseph Koshakow Reviewed-by: Jian He Discussion: https://postgr.es/m/CAAvxfHdBPOyEGS7s%2Bxf4iaW0-cgiq25jpYdWBqQqvLtLe_t6tw%40mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/108d2adb9e9e084cd57bf514d06ef4b954719ffa Modified Files -------------- src/backend/utils/adt/jsonfuncs.c | 7 ++++--- src/test/regress/expected/jsonb.out | 18 ++++++++++++++++++ src/test/regress/sql/jsonb.sql | 3 +++ 3 files changed, 25 insertions(+), 3 deletions(-)