Thread: Re: JIT: Remove some unnecessary instructions.

On 8/30/24 5:55 AM, Xing Guo wrote:
> I find there are some unnecessary load/store instructions being
> emitted by the JIT compiler.

Well spotted! All of these are obvious dead instructions and while LLVM 
might be able to optimize them away there is no reason to create extra 
work for the optimizer.

The patch looks good, applies and the tests passes.

Andreas

On 9/2/24 4:23 AM, Xing Guo wrote:
> Thanks for testing it! I spotted another unnecessary store instruction
> and added it in my V2 patch.

Another well-spotted unnecessary store. Nice!

I think this patch is ready for committer. It is simple and pretty 
obviously correct.

Andreas

On 9/2/24 9:06 PM, Andreas Karlsson wrote:
> On 9/2/24 4:23 AM, Xing Guo wrote:
>> Thanks for testing it! I spotted another unnecessary store instruction
>> and added it in my V2 patch.
> 
> Another well-spotted unnecessary store. Nice!
> 
> I think this patch is ready for committer. It is simple and pretty 
> obviously correct.

Oh, and please add your patch to the commitfest app so it is not lost.

https://commitfest.postgresql.org/50/

Andreas

On 02/09/2024 22:06, Andreas Karlsson wrote:
> On 9/2/24 4:23 AM, Xing Guo wrote:
>> Thanks for testing it! I spotted another unnecessary store instruction
>> and added it in my V2 patch.
> 
> Another well-spotted unnecessary store. Nice!
> 
> I think this patch is ready for committer. It is simple and pretty 
> obviously correct.

Committed, thanks!

-- 
Heikki Linnakangas
Neon (https://neon.tech)