Thread: pgsql: At end of recovery, reset all sinval-managed caches.

pgsql: At end of recovery, reset all sinval-managed caches.

From
Noah Misch
Date:
At end of recovery, reset all sinval-managed caches.

An inplace update's invalidation messages are part of its transaction's
commit record.  However, the update survives even if its transaction
aborts or we stop recovery before replaying its transaction commit.
After recovery, a backend that started in recovery could update the row
without incorporating the inplace update.  That could result in a table
with an index, yet relhasindex=f.  That is a source of index corruption.

This bulk invalidation avoids the functional consequences.  A future
change can fix the !RecoveryInProgress() scenario without changing the
WAL format.  Back-patch to v17 - v12 (all supported versions).  v18 will
instead add invalidations to WAL.

Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/da9950456463456b8e2c38f5a09bf33fe958a595

Modified Files
--------------
src/backend/access/transam/xlog.c   | 25 ++++++++++++++++++++++
src/backend/storage/ipc/sinvaladt.c | 41 +++++++++++++++++++++++++++++++++++++
src/include/storage/sinvaladt.h     |  1 +
3 files changed, 67 insertions(+)