Thread: pgsql: Remove unused #include's from contrib, pl, test .c files

pgsql: Remove unused #include's from contrib, pl, test .c files

From
Peter Eisentraut
Date:
Remove unused #include's from contrib, pl, test .c files

as determined by IWYU

Similar to commit dbbca2cf299, but for contrib, pl, and src/test/.

Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>
Discussion: https://www.postgresql.org/message-id/flat/0df1d5b1-8ca8-4f84-93be-121081bde049%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9be4e5d293b554d8a0800790c57fc707a3b5cf0f

Modified Files
--------------
contrib/amcheck/verify_heapam.c                    |  6 +++-
contrib/amcheck/verify_nbtree.c                    |  2 --
contrib/auth_delay/auth_delay.c                    |  2 --
contrib/auto_explain/auto_explain.c                |  2 --
contrib/basic_archive/basic_archive.c              |  1 -
contrib/bloom/blcost.c                             |  1 -
contrib/bloom/blinsert.c                           |  4 +--
contrib/bloom/blscan.c                             |  4 ---
contrib/bloom/blutils.c                            |  5 +--
contrib/bloom/blvacuum.c                           |  4 ---
contrib/bloom/blvalidate.c                         |  2 --
contrib/btree_gin/btree_gin.c                      |  3 --
contrib/btree_gist/btree_bit.c                     |  3 +-
contrib/btree_gist/btree_bool.c                    |  1 -
contrib/btree_gist/btree_bytea.c                   |  3 +-
contrib/btree_gist/btree_date.c                    |  2 +-
contrib/btree_gist/btree_enum.c                    |  2 +-
contrib/btree_gist/btree_inet.c                    |  1 -
contrib/btree_gist/btree_interval.c                |  2 +-
contrib/btree_gist/btree_macaddr.c                 |  2 +-
contrib/btree_gist/btree_macaddr8.c                |  2 +-
contrib/btree_gist/btree_text.c                    |  3 +-
contrib/btree_gist/btree_time.c                    |  2 +-
contrib/btree_gist/btree_ts.c                      |  4 +--
contrib/btree_gist/btree_utils_num.h               |  1 -
contrib/btree_gist/btree_utils_var.c               |  3 +-
contrib/btree_gist/btree_utils_var.h               |  1 -
contrib/citext/citext.c                            |  2 +-
contrib/dict_xsyn/dict_xsyn.c                      |  2 +-
contrib/fuzzystrmatch/fuzzystrmatch.c              |  1 -
contrib/intarray/_int_bool.c                       |  1 -
contrib/intarray/_int_selfuncs.c                   |  3 +-
contrib/isn/isn.c                                  |  1 -
contrib/lo/lo.c                                    |  2 +-
contrib/ltree/ltree_io.c                           |  1 -
contrib/ltree/ltree_op.c                           |  4 +--
contrib/pageinspect/brinfuncs.c                    |  4 ---
contrib/pageinspect/fsmfuncs.c                     |  2 +-
contrib/pageinspect/ginfuncs.c                     |  3 --
contrib/pageinspect/gistfuncs.c                    |  3 --
contrib/pageinspect/heapfuncs.c                    |  1 -
contrib/pg_freespacemap/pg_freespacemap.c          |  2 +-
contrib/pg_prewarm/autoprewarm.c                   |  9 +----
contrib/pg_stat_statements/pg_stat_statements.c    |  3 --
contrib/pg_surgery/heap_surgery.c                  |  4 +--
contrib/pg_visibility/pg_visibility.c              |  2 --
contrib/pgcrypto/pgcrypto.c                        |  1 -
contrib/pgrowlocks/pgrowlocks.c                    |  2 +-
contrib/pgstattuple/pgstatapprox.c                 |  6 ----
contrib/pgstattuple/pgstatindex.c                  |  3 --
contrib/pgstattuple/pgstattuple.c                  |  1 -
contrib/postgres_fdw/connection.c                  |  4 ---
contrib/postgres_fdw/deparse.c                     |  2 --
contrib/postgres_fdw/option.c                      |  1 -
contrib/postgres_fdw/postgres_fdw.c                |  3 --
contrib/spi/moddatetime.c                          |  2 +-
contrib/tablefunc/tablefunc.c                      |  2 +-
contrib/tablefunc/tablefunc.h                      | 39 ----------------------
contrib/tsm_system_rows/tsm_system_rows.c          |  1 -
contrib/tsm_system_time/tsm_system_time.c          |  1 -
contrib/unaccent/unaccent.c                        |  2 --
contrib/xml2/xpath.c                               |  1 -
contrib/xml2/xslt_proc.c                           |  3 --
src/pl/plperl/plperl.c                             |  1 -
src/pl/plpgsql/src/pl_comp.c                       |  3 +-
src/pl/plpgsql/src/pl_exec.c                       |  5 ---
src/pl/plpython/plpy_cursorobject.c                |  2 --
src/pl/plpython/plpy_exec.c                        |  4 +--
src/pl/plpython/plpy_planobject.c                  |  1 -
src/pl/plpython/plpy_plpymodule.c                  |  3 --
src/pl/plpython/plpy_procedure.c                   |  3 --
src/pl/plpython/plpy_spi.c                         |  3 --
src/pl/plpython/plpy_util.c                        |  1 -
src/pl/tcl/pltcl.c                                 |  3 +-
src/test/modules/delay_execution/delay_execution.c |  2 +-
src/test/modules/dummy_index_am/dummy_index_am.c   |  2 --
.../ldap_password_func/ldap_password_func.c        |  4 +--
src/test/modules/libpq_pipeline/libpq_pipeline.c   |  2 --
src/test/modules/plsample/plsample.c               |  2 +-
.../modules/test_ddl_deparse/test_ddl_deparse.c    |  1 -
src/test/modules/test_integerset/test_integerset.c |  4 ---
src/test/modules/test_oat_hooks/test_oat_hooks.c   |  1 -
src/test/modules/test_radixtree/test_radixtree.c   |  2 --
src/test/modules/test_regex/test_regex.c           |  1 -
.../modules/test_resowner/test_resowner_basic.c    |  2 --
.../modules/test_resowner/test_resowner_many.c     |  1 -
src/test/modules/test_rls_hooks/test_rls_hooks.c   |  1 -
src/test/modules/test_shm_mq/setup.c               |  1 -
src/test/modules/test_slru/test_multixact.c        |  2 +-
src/test/modules/test_tidstore/test_tidstore.c     |  1 -
src/test/modules/worker_spi/worker_spi.c           |  4 ---
src/test/regress/pg_regress.c                      |  1 -
src/test/regress/regress.c                         |  3 --
93 files changed, 40 insertions(+), 218 deletions(-)


Re: pgsql: Remove unused #include's from contrib, pl, test .c files

From
Peter Geoghegan
Date:
On Mon, Oct 28, 2024 at 3:03 AM Peter Eisentraut <peter@eisentraut.org> wrote:
> Remove unused #include's from contrib, pl, test .c files

This broke WAL_DEBUG builds, which rely on TopMemoryContext within xlog.c.

--
Peter Geoghegan



Re: pgsql: Remove unused #include's from contrib, pl, test .c files

From
Peter Geoghegan
Date:
On Mon, Oct 28, 2024 at 11:48 AM Peter Geoghegan <pg@bowt.ie> wrote:
> This broke WAL_DEBUG builds, which rely on TopMemoryContext within xlog.c.

Minor correction: it was actually commit e18512c0, not this similar commit.

--
Peter Geoghegan



Re: pgsql: Remove unused #include's from contrib, pl, test .c files

From
Peter Eisentraut
Date:
On 28.10.24 16:56, Peter Geoghegan wrote:
> On Mon, Oct 28, 2024 at 11:48 AM Peter Geoghegan <pg@bowt.ie> wrote:
>> This broke WAL_DEBUG builds, which rely on TopMemoryContext within xlog.c.
> 
> Minor correction: it was actually commit e18512c0, not this similar commit.

fixed