Thread: Re: Remove a unnecessary backslash in CopyFrom
Yugo Nagata <nagata@sraoss.co.jp> 于2024年11月12日周二 10:46写道：
Hi,
I found a unnecessary backslash in CopyFrom().
if (cstate->opts.reject_limit > 0 && \
cstate->num_errors > cstate->opts.reject_limit)
It can be removed because this is not in a macro.
I've attached a patch.
Yeah, agree. The patch LGTM.
Thanks,
Tender Wang
On 2024/11/12 11:58, Tender Wang wrote: > > > Yugo Nagata <nagata@sraoss.co.jp <mailto:nagata@sraoss.co.jp>> 于2024年11月12日周二 10:46写道： > > Hi, > > I found a unnecessary backslash in CopyFrom(). > > if (cstate->opts.reject_limit > 0 && \ > cstate->num_errors > cstate->opts.reject_limit) > > It can be removed because this is not in a macro. > I've attached a patch. > > > Yeah, agree. The patch LGTM. Thanks for the report and patch! This is a mistake in commit 4ac2a9bece. I'll commit the patch. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
On 2024/11/12 12:31, Fujii Masao wrote: > > > On 2024/11/12 11:58, Tender Wang wrote: >> >> >> Yugo Nagata <nagata@sraoss.co.jp <mailto:nagata@sraoss.co.jp>> 于2024年11月12日周二 10:46写道： >> >> Hi, >> >> I found a unnecessary backslash in CopyFrom(). >> >> if (cstate->opts.reject_limit > 0 && \ >> cstate->num_errors > cstate->opts.reject_limit) >> >> It can be removed because this is not in a macro. >> I've attached a patch. >> >> >> Yeah, agree. The patch LGTM. > > Thanks for the report and patch! This is a mistake in commit 4ac2a9bece. > I'll commit the patch. Pushed. Thanks! Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION