Thread: Re: Fix array access (src/bin/pg_dump/pg_dump.c)

Re: Fix array access (src/bin/pg_dump/pg_dump.c)

From
Alvaro Herrera
Date:
On 2024-Nov-12, Ranier Vilela wrote:

> Per Coverity.
> 
> The function *determineNotNullFlags* has a little oversight.
> The struct field *notnull_islocal* is an array.
> 
> I think this is a simple typo.
> Fix using array notation access.

Yeah, thanks, I had been made aware of this bug.  Before fixing I'd like
to construct a test case that tickles that code, because it's currently
uncovered  *shudder*

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)



Re: Fix array access (src/bin/pg_dump/pg_dump.c)

From
Ranier Vilela
Date:
Em ter., 12 de nov. de 2024 às 16:11, Alvaro Herrera <alvherre@alvh.no-ip.org> escreveu:
On 2024-Nov-12, Ranier Vilela wrote:

> Per Coverity.
>
> The function *determineNotNullFlags* has a little oversight.
> The struct field *notnull_islocal* is an array.
>
> I think this is a simple typo.
> Fix using array notation access.

Yeah, thanks, I had been made aware of this bug.  Before fixing I'd like
to construct a test case that tickles that code, because it's currently
uncovered  *shudder*
Thanks for taking care of this.

best regards,
Ranier Vilela