Thread: Re: Tweak some codes format in gist.c
> On 15 Nov 2024, at 14:48, Tender Wang <tndrwang@gmail.com> wrote: > > Hi, > > I found some inconsistent code format in gist.c. > See the attached. I’d suggest to combine such changes with some real code modification done nearby. There’s plenty of GiST patches on commitfest. Thanks! Best regards, Andrey Borodin.
Andrey M. Borodin <x4mmm@yandex-team.ru> 于2024年11月15日周五 17:57写道：
> On 15 Nov 2024, at 14:48, Tender Wang <tndrwang@gmail.com> wrote:
>
> Hi,
>
> I found some inconsistent code format in gist.c.
> See the attached.
I’d suggest to combine such changes with some real code modification done nearby. There’s plenty of GiST patches on commitfest.
Thanks!
Yeah, agree. According to the nearby real code modification, I made the change.
Thanks,
Tender Wang
Michael Paquier <michael@paquier.xyz> 于2024年11月18日周一 12:50写道：
On Fri, Nov 15, 2024 at 02:56:57PM +0500, Andrey M. Borodin wrote:
> I’d suggest to combine such changes with some real code modification
> done nearby. There’s plenty of GiST patches on commitfest.
We do a lot of cosmetic fixes like this one, and sometimes we also
have the argument that these should not be blindly included in other
patches as that's just unrelated noise.
FWIW, I don't really mind in this case and this is consistent with the
surroundings, so applied on HEAD.
There is one more in trgm.h, though it's OK as-is, as well.
--
Michael
Thanks for pushing.
Thanks,
Tender Wang