Thread: Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT

On 19/11/2024 01:20, Masahiko Sawada wrote:
> I realized that building test_radixtree.c with TEST_SHARED_RT fails
> because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> it's missing some header files to include. I've attached a patch to
> include necessary header files in radixtree.h to make it
> self-contained.

If those includes are only needed when RT_SHMEM is defined, I suggest
they should be guarded by #ifdef RT_SHMEM, per Peter E's IWYU efforts
lately.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La rebeldía es la virtud original del hombre" (Arthur Schopenhauer)

On Tue, Nov 19, 2024 at 1:14 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 19/11/2024 01:20, Masahiko Sawada wrote:
> > I realized that building test_radixtree.c with TEST_SHARED_RT fails
> > because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> > it's missing some header files to include. I've attached a patch to
> > include necessary header files in radixtree.h to make it
> > self-contained.
>
> If those includes are only needed when RT_SHMEM is defined, I suggest
> they should be guarded by #ifdef RT_SHMEM, per Peter E's IWYU efforts
> lately.

Indeed. I'll incorporate it in the next version.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com