Thread: Re: Document How Commit Handles Aborted Transactions
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, failed Spec compliant: tested, failed Documentation: tested, failed Summary: --------- The patch adds documentation to clarify how PostgreSQL handles aborted transactions during the commit process. The changesare clear and improve the existing documentation. Testing: -------- 1. Manually applied the patch to the latest master branch (commit 4cffc93). 2. Fixed SGML structure issues in `advanced.sgml` and `commit.sgml` by wrapping `<varlistentry>` in `<variablelist>`. 3. Rebuilt the documentation using `make html`. 4. Verified the new sections are present and correctly formatted in the generated HTML. Feedback: --------- - The patch was manually applied due to conflicts in `advanced.sgml` and `commit.sgml`. - Fixed invalid SGML structure by wrapping `<varlistentry>` in `<variablelist>`. - The documentation is accurate and follows PostgreSQL’s style guidelines. - No additional issues were found. Recommendation: --------------- Ready for committer. No objections. The new status of this patch is: Ready for Committer
Ahmed,
Thank you for the review.
I'm a bit confused by the reports of apply and compile errors. I didn't touch anything involving "varlist" and see no errors then or now in my Meson ninja build. Nor does the CI report any.
On Fri, Feb 14, 2025 at 2:01 PM Ahmed Ashour <a8087027@gmail.com> wrote:
Feedback:
---------
- The patch was manually applied due to conflicts in `advanced.sgml` and `commit.sgml`.
- Fixed invalid SGML structure by wrapping `<varlistentry>` in `<variablelist>`.
If those errors were/are real this wouldn't be ready to commit. But as they seem to be a local environment issue on your end, and you agree with the content, I'll keep it ready to commit.
David J.