Thread: Removing rm regress.def

Removing rm regress.def

From
Christoph Berg
Date:
pgxs.mk is cleaning up a file "regress.def" if PORTNAME=win, but the
only reference to that file I could find is in the original commit
from 1999 adding that "rm" rule (and several commits moving the rule
around later).

Given that the PORTNAME is wrong (should be win32), it's probably safe
to just delete the rule.

Christoph

Attachment

Re: Removing rm regress.def

From
Tom Lane
Date:
Christoph Berg <myon@debian.org> writes:
> pgxs.mk is cleaning up a file "regress.def" if PORTNAME=win, but the
> only reference to that file I could find is in the original commit
> from 1999 adding that "rm" rule (and several commits moving the rule
> around later).

> Given that the PORTNAME is wrong (should be win32), it's probably safe
> to just delete the rule.

Yeah, seems quite bogus.  It's harmless though, so I don't
see a need to back-patch, do you?

            regards, tom lane



Re: Removing rm regress.def

From
Tom Lane
Date:
Christoph Berg <myon@debian.org> writes:
> Re: Tom Lane
>> Yeah, seems quite bogus.  It's harmless though, so I don't
>> see a need to back-patch, do you?

> Other than it being confusing, it doesn't hurt.

OK, applied to master only.

            regards, tom lane