Thread: Re: Remove unneeded check for XLH_INSERT_ALL_FROZEN in heap_xlog_insert

On 6/24/25 19:41, Melanie Plageman wrote:
> Hi,
> 
> I noticed that 8e03eb92e9a forgot one line when reverting 39b66a91bd.
> There is an extraneous check for XLH_INSERT_ALL_FROZEN_SET in
> heap_xlog_insert() -- even though heap_insert() never freezes tuples.
> It doesn't hurt anything, but I found it confusing, so I think it is
> worth removing. I don't think it's worth backpatching, so I don't know
> if that means that this commit shouldn't go in master until after we
> branch.

Thanks for noticing this. I'd probably be +0.5 to backpatch this, even
if it's ultimately harmless, just to keep the code not confusing.


regards

-- 
Tomas Vondra

On Tue, Jun 24, 2025 at 1:53 PM Tomas Vondra <tomas@vondra.me> wrote:
>
> Thanks for noticing this. I'd probably be +0.5 to backpatch this, even
> if it's ultimately harmless, just to keep the code not confusing.

Okay, I can backpatch this (to 14, I believe). I'll wait until the
thread has been around for closer to 24 hours before doing anything,
though.

- Melanie

On Tue, Jun 24, 2025 at 4:48 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> Okay, I can backpatch this (to 14, I believe). I'll wait until the
> thread has been around for closer to 24 hours before doing anything,
> though.

Pushed and back-patched through 14.

- Melanie