Thread: Re: Typo in pg_stat_activity definition
Thank you for comments!
>> One thing that you are forgetting is that the regression
>> tests are going to fail: rules.out reports the definition of
>> pg_stat_activity, and the characters casing matters in this case.
>
>I doubt it --- the regression tests will show deparsing results,
>which shouldn't change.
Yes, applying this patch will not cause the 'rules' test to fail.
Even if the pg_stat_activity view definition information in system_views.sql is capitalized (inconsistency is fixed) by this patch, it will be lowercase when this view is installed in database. So, the test result does not change.
Just to be sure, I ran the 'make check' and 'make check-world', and I confirmed that all tests were passed.
Regards.
On Mon, Jun 30, 2025 at 04:03:01PM +0900, Daisuke Higuchi wrote: > Yes, applying this patch will not cause the 'rules' test to fail. > Even if the pg_stat_activity view definition information in > system_views.sql is capitalized (inconsistency is fixed) by this patch, it > will be lowercase when this view is installed in database. So, the test > result does not change. Yes, that was the part where I need to learn to read my greps more correctly. Applied as-is on HEAD. -- Michael