Postgres Pro
Downloads
Home   >   mailing lists

Re: ECPG Refactor: move sqlca variable in ecpg_log() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: ECPG Refactor: move sqlca variable in ecpg_log()
Date
Msg-id 911868.1729273425@sss.pgh.pa.us
Whole thread Raw
In response to Re: ECPG Refactor: move sqlca variable in ecpg_log()  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Tree view 
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> I've attached the latest version of the patch, now including the commit log.
> Unless there are any objections, I'll proceed with committing it.

LGTM.  Maybe move down the sqlca variable declaration, so that the
declarations still match the order in which the variables are
initialized?  That's just cosmetic of course.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Nathan Bossart
Date:
Subject: Re: Use more CppAsString2() in pg_amcheck.c
Next
From: Jeff Davis
Date:
Subject: Inconsistent use of relpages = -1