Re: Crash in add_paths_to_append_rel - Mailing list pgsql-hackers

From David Rowley
Subject Re: Crash in add_paths_to_append_rel
Date
Msg-id CAApHDvrNk2X6y592S5esBchTOJuvjnGWwX9-epSK3EGoaqfwOA@mail.gmail.com
Whole thread Raw
In response to Crash in add_paths_to_append_rel  (Richard Guo <guofenglinux@gmail.com>)
Responses Re: Crash in add_paths_to_append_rel
Re: Crash in add_paths_to_append_rel
List pgsql-hackers
On Mon, 9 Oct 2023 at 22:49, Richard Guo <guofenglinux@gmail.com> wrote:
> I came across a crash in add_paths_to_append_rel() with the query below.

> It was introduced by commit a8a968a8 where we referenced
> cheapest_startup_path->param_info without first checking that we have a
> valid cheapest_startup_path.

I pushed this with just minor adjustments to the comments you wrote. I
didn't feel the need to reiterate on the set_cheapest() comments.

David



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Next
From: Andres Freund
Date:
Subject: Re: Lowering the default wal_blocksize to 4K