Re: Crash in add_paths_to_append_rel - Mailing list pgsql-hackers

From Andy Fan
Subject Re: Crash in add_paths_to_append_rel
Date
Msg-id CAKU4AWr=OKPbaQBtJsdY0LAOW4r8aeU+EgCJdqjai_TnEv1U8A@mail.gmail.com
Whole thread Raw
In response to Re: Crash in add_paths_to_append_rel  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers


On Tue, Oct 10, 2023 at 11:52 AM David Rowley <dgrowleyml@gmail.com> wrote:
On Mon, 9 Oct 2023 at 22:49, Richard Guo <guofenglinux@gmail.com> wrote:
> I came across a crash in add_paths_to_append_rel() with the query below.

> It was introduced by commit a8a968a8 where we referenced
> cheapest_startup_path->param_info without first checking that we have a
> valid cheapest_startup_path.

I pushed this with just minor adjustments to the comments you wrote. I
didn't feel the need to reiterate on the set_cheapest() comments.

 
 Thanks Richard for the report and also Thanks you David for the push!

--
Best Regards
Andy Fan

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Add a new BGWORKER_BYPASS_ROLELOGINCHECK flag
Next
From: Gurjeet Singh
Date:
Subject: Minor edit to src/bin/pg_upgrade/IMPLEMENTAION