Re: Logical replication launcher did not automatically restart when got SIGKILL - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Logical replication launcher did not automatically restart when got SIGKILL
Date
Msg-id CAHGQGwFuTCT4OYGy3ep=21O+KzD1UN3TbKuMvouYd0dLiAzngA@mail.gmail.com
Whole thread Raw
In response to Re: Logical replication launcher did not automatically restart when got SIGKILL  ("cca5507" <cca5507@qq.com>)
Responses Re: Logical replication launcher did not automatically restart when got SIGKILL
List pgsql-hackers
On Fri, Jul 25, 2025 at 10:53 PM cca5507 <cca5507@qq.com> wrote:
>
> > For example, we could add a check like the following to 013_crash_restart.pl.
> > Thoughts?
> >
> > -----------------
> > is($node->safe_psql('postgres',
> > "SELECT count(*) = 1 FROM pg_stat_activity WHERE backend_type =
> > 'logical replication launcher'"),
> > 't',
> > 'logical replication launcher is running after crash');
> > -----------------

Patch attached.
I confirmed that the test fails when applied to a version before
commit b5d084c5353 (i.e., before the bug was fixed), and it passes
on HEAD with the patch applied.

> Agree, but we need note that the logical replication launcher won't be registered in some case. (see
ApplyLauncherRegister())

Since 013_crash_restart.pl doesn't set any parameters that would
prevent the logical replication launcher from starting, I think
we don't need to worry about that. No??

Regards,

--
Fujii Masao

Attachment

pgsql-hackers by date:

Previous
From: Sami Imseih
Date:
Subject: Re: track generic and custom plans in pg_stat_statements
Next
From: Paul A Jungwirth
Date:
Subject: Re: PoC: adding CustomJoin, separate from CustomScan