Re: OOM in spgist insert - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: OOM in spgist insert
Date
Msg-id CALT9ZEHLM8+4hPinp=eKF0nJu+Tu8Dwc0koc--T9z-6RW4t6bQ@mail.gmail.com
Whole thread Raw
In response to Re: OOM in spgist insert  (Pavel Borisov <pashkin.elfe@gmail.com>)
List pgsql-hackers

Now when checking for shortening of  leaf tuple is added LongValuesOK become slightly redundant. I'd propose to replace it with more legible name as LongValuesOK doesn't mean they are warranted to be ok just that we can try to shorten them? What about tryShortening, trySuffixing or can(Try)ShortenTuple?
Or maybe it's even more logical now to invert it and make dontTrySuffixing for use in the opclasses for kd-tree, quadtree etc which are warranted to have the same key data length at any tree level ?

--
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com

pgsql-hackers by date:

Previous
From: "houzj.fnst@fujitsu.com"
Date:
Subject: RE: Parallel INSERT SELECT take 2
Next
From: Greg Nancarrow
Date:
Subject: Re: Parallel scan with SubTransGetTopmostTransaction assert coredump