Re: [HACKERS] Why does logical replication launcher setapplication_name? - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: [HACKERS] Why does logical replication launcher setapplication_name?
Date
Msg-id e6c6e528-b20a-519f-c9a2-b01f63edf62f@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Why does logical replication launcher setapplication_name?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On 03/06/17 05:18, Peter Eisentraut wrote:
> On 6/2/17 16:44, Petr Jelinek wrote:
>> However, I am not sure about the bgw_name_extra. I think I would have
>> preferred keeping full bgw_name field which would be used where full
>> name is needed and bgw_type where only the worker type is used. The
>> concatenation just doesn't sit well with me, especially if it requires
>> the bgw_name_extra to start with space.
> 
> I see your point.  There are also some i18n considerations to think through.
> 

So thinking a bit more, I wonder if we could simply do following:
- remove the application_name from logical workers
- add bgw_type and use it for worker type (if empty, use 'bgworker' like
now), would be probably nice if parallel workers added something to
indicate they are parallel workers there as well
- remove the 'bgworker:' prefix for ps display and just use the bgw_name

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: "Jim Van Fleet"
Date:
Subject: [HACKERS] HACKERS[PROPOSAL] split ProcArrayLock into multiple parts
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Make ANALYZE more selective about what is a "most common value"?