Postgres Pro
Downloads
Home   >   mailing lists

Thread: zheap storage_engine parameter, shouldn't this raise an error?

zheap storage_engine parameter, shouldn't this raise an error?

From
Daniel Westermann
Date:

Hi,


I believe this should raise an error or at least a warning?


postgres=# alter system set storage_engine = 'zheap';
ALTER SYSTEM
postgres=# alter system set storage_engine = 'zheap2';
ALTER SYSTEM
postgres=# alter system set storage_engine = 'zheap3';
ALTER SYSTEM
postgres=#

Regards
Daniel




Daniel Westermann | Delivery Manager & Open Infrastructure Technology Leader
Phone: +41 32 422 96 00 | Mobile: +41 79 927 24 46 | Fax: +41 32 422 96 15
dbi services, Voltastrasse 104 | CH-4056 Basel
daniel.westermann@dbi-services.com
www.dbi-services.com 


Attachment

Re: zheap storage_engine parameter, shouldn't this raise an error?

From
Amit Kapila
Date:
On Sat, Nov 3, 2018 at 3:13 PM Daniel Westermann <daniel.westermann@dbi-services.com> wrote:

Hi,


I believe this should raise an error or at least a warning?


postgres=# alter system set storage_engine = 'zheap';
ALTER SYSTEM
postgres=# alter system set storage_engine = 'zheap2';
ALTER SYSTEM
postgres=# alter system set storage_engine = 'zheap3';
ALTER SYSTEM
postgres=#


Sure, if we want we can raise the error or warning for this, but this is a parameter mainly to test zheap with existing set of regression tests.  I am not sure if we want to keep it or even if we want to have any such parameter for testing purpose in what form it will be present.  So, adding more checks at this stage around this parameter doesn't seem advisable to me.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment

Re: zheap storage_engine parameter, shouldn't this raise an error?

From
Amit Kapila
Date:
On Sat, Nov 3, 2018 at 3:21 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Sat, Nov 3, 2018 at 3:13 PM Daniel Westermann <daniel.westermann@dbi-services.com> wrote:
>>
>> Hi,
>>
>>
>> I believe this should raise an error or at least a warning?
>>
>
> Sure, if we want we can raise the error or warning for this, but this is a parameter mainly to test zheap with
existingset of regression tests.  I am not sure if we want to keep it or even if we want to have any such parameter for
testingpurpose in what form it will be present.  So, adding more checks at this stage around this parameter doesn't
seemadvisable to me. 
>

Instead of starting new threads for each report, it might be better to
report it on the zheap thread [1].

[1] - https://www.postgresql.org/message-id/CAA4eK1%2BYtM5vxzSM2NZm%2BpC37MCwyvtkmJrO_yRBQeZDp9Wa2w%40mail.gmail.com

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com