Re: amcheck: Remove unused IndexCheckableCallback typedef - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: amcheck: Remove unused IndexCheckableCallback typedef
Date
Msg-id 4CBF8299-22E1-4CF8-80B0-32EEF8223911@yandex-team.ru
Whole thread Raw
Responses Re: amcheck: Remove unused IndexCheckableCallback typedef
List pgsql-hackers

> On 4 Jul 2025, at 10:50, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
> From the discussion in [1], it seems this typedef was originally used as
> a function argument in early versions of the patch. However,
> the argument was removed in v23, and the typedef was accidentally left behind.

Yes, your analysis is correct. We could make common checking function and argument was not needed.

>
> The attached patch removes this unused typedef to clean up the dead code.
> Thoughts?

Looks good to me. Thanks for fixing this!


Best regards, Andrey Borodin.


pgsql-hackers by date:

Previous
From: Nazir Bilal Yavuz
Date:
Subject: Re: Explicitly enable meson features in CI
Next
From: Xuneng Zhou
Date:
Subject: Re: Add progressive backoff to XactLockTableWait functions