Hi,
On Thu, 3 Jul 2025 at 17:07, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 3 Jul 2025, at 15:50, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> > On Thu, 3 Jul 2025 at 16:21, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> >> + # Like 'MESON_COMMON_FEATURES' but not shared with 'Windows - VS' task too
> >> + MESON_NON_VS_FEATURES: >-
> >>
> >> I'm not a fan of this name, it feel a bit unintuitive to describe what it isn't
> >> instead of what it is. How about MESON_LINUX_UNIX_FEATURES or something along
> >> those lines?
> >
> > I agree that MESON_NON_VS_FEATURES is not intuitive but can MinGW be
> > considered as LINUX or UNIX?
>
> That is an excellent question, according to our fine documentation it is a
> "Unix-like build environment".
>
> An alternative approach would be to instead of having opt-in's for non-Windows
> have opt-outs for Windows, ie a MESON_WINDOWS_EXCLUDES which does =disabled on
> the specific features we dont want on Windows?
I think this would make things complicated. Instead, we can set
Windows VS tasks' features in its task, then we can have a one common
feature variable at the top level and have a comment about this
variable not being used in the Windows VS task. Basically the same
with your approach but instead of using a common feature variable and
disabling features from it, we enable them again in the Windows VS
task. I used this approach in the v3-0002.
>
> >> The MinGW build no longer disables nls, or am I missing something?
> >
> > Auto features are already disabled. So, there is no need to disable
> > nls manually. By saying that, it would be better to remove this
> > comment now.
>
> Aha, that explains it. Maybe reword the comment to retain the knowledge for
> the future without making it sound like something is missing from the command.
> How about something like:
>
> - # disable -Dnls as the number of files it creates cause a noticable slowdown
> + # -Dnls need to be disabled as the number of files it creates cause a
> + # noticable slowdown
Yes, I think this is better. Done.
--
Regards,
Nazir Bilal Yavuz
Microsoft
