Re: Explicitly enable meson features in CI - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Explicitly enable meson features in CI
Date
Msg-id E47BC747-B7AE-48B8-98B8-DA2023A0FB0A@yesql.se
Whole thread Raw
In response to Re: Explicitly enable meson features in CI  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
List pgsql-hackers
> On 4 Jul 2025, at 09:33, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> On Thu, 3 Jul 2025 at 17:07, Daniel Gustafsson <daniel@yesql.se> wrote:

>> An alternative approach would be to instead of having opt-in's for non-Windows
>> have opt-outs for Windows, ie a MESON_WINDOWS_EXCLUDES which does =disabled on
>> the specific features we dont want on Windows?
>
> I think this would make things complicated.

I think you're right.

> Instead, we can set
> Windows VS tasks' features in its task, then we can have a one common
> feature variable at the top level and have a comment about this
> variable not being used in the Windows VS task. Basically the same
> with your approach but instead of using a common feature variable and
> disabling features from it, we enable them again in the Windows VS
> task. I used this approach in the v3-0002.

The proposal in v3 strikes a good balance between avoiding repetition and being
readable.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Nikita Malakhov
Date:
Subject: Re: Support for 8-byte TOAST values (aka the TOAST infinite loop problem)
Next
From: Ashutosh Bapat
Date:
Subject: Re: PG 18 beta1 release notes misses mention of pg_noreturn